feat(generator): introduce new didGenerateDirective hook #1818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new `didGenerateDirective` hook that is invoked AFTER generating the directive. This PR also fix directive generation logic to ensure hooks are only called once (when generating the directive). Previously we were always invoking `willGenerateDirective` hook regardless whether the directive was already generated or not (which lead to creation of new directive when modifying the directive in the new `didGenerateDirective` hook).
dariuszkuc
changed the title
samuelAndalon
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds new
didGenerateDirectivehook that is invoked AFTER generating the directive. This PR also fix directive generation logic to ensure hooks are only called once (when generating the directive). Previously we were always invokingwillGenerateDirectivehook regardless whether the directive was already generated or not (which lead to creation of new directive when modifying the directive in the newdidGenerateDirectivehook).🔗 Related Issues
Type generation still suffers from the same bug (#1815)