Skip to content

feat: new hook for modifying object types #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Jun 6, 2019

Fixes #231

Adds a new hook that can be used to modify all the GraphQLTypes that get generated from reflection. This allows for runtime documentation or any other changes that may want to be made to types after they are fully generated

Fixes ExpediaGroup#231

Adds a new hook that can be used to modify all the GraphQLTypes that get generated from reflection. This allows for runtime documentation or any other changes that may want to be made to types after they are fully generated
@smyrick smyrick added changes: minor Changes require a minor version type: enhancement New feature or request labels Jun 6, 2019
@smyrick smyrick marked this pull request as ready for review June 6, 2019 20:55
@smyrick smyrick closed this Jun 6, 2019
@smyrick smyrick reopened this Jun 6, 2019
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #232 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #232      +/-   ##
============================================
- Coverage     98.43%   98.29%   -0.15%     
  Complexity      178      178              
============================================
  Files            57       57              
  Lines           575      585      +10     
  Branches         99      103       +4     
============================================
+ Hits            566      575       +9     
  Misses            4        4              
- Partials          5        6       +1
Impacted Files Coverage Δ Complexity Δ
...otlin/com/expedia/graphql/generator/TypeBuilder.kt 100% <100%> (ø) 19 <0> (ø) ⬇️
.../com/expedia/graphql/hooks/SchemaGeneratorHooks.kt 100% <100%> (ø) 0 <0> (ø) ⬇️
...m/expedia/graphql/execution/FunctionDataFetcher.kt 86.95% <0%> (-3.96%) 11% <0%> (ø)
...expedia/graphql/generator/types/FunctionBuilder.kt 100% <0%> (ø) 13% <0%> (ø) ⬇️
.../com/expedia/graphql/generator/state/TypesCache.kt 100% <0%> (ø) 21% <0%> (ø) ⬇️
...raphql/generator/extensions/kPropertyExtensions.kt 100% <0%> (ø) 0% <0%> (ø) ⬇️
...otlin/com/expedia/graphql/DirectiveWiringHelper.kt 100% <0%> (ø) 11% <0%> (ø) ⬇️
.../graphql/generator/extensions/graphQLExtensions.kt 91.3% <0%> (+0.39%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bf396e...830ef16. Read the comment docs.

@smyrick smyrick merged commit 8136a43 into ExpediaGroup:master Jun 13, 2019
@smyrick smyrick deleted the graphql-type-hook branch June 13, 2019 20:40
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Fixes ExpediaGroup#231

Adds a new hook that can be used to modify all the GraphQLTypes that get generated from reflection. This allows for runtime documentation or any other changes that may want to be made to types after they are fully generated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: minor Changes require a minor version type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Support hooks to add custom documentation to objects, fields, arguments and enum values
2 participants