Skip to content

Explicit support for deprecated directive in the schema #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 3, 2019
Merged

Explicit support for deprecated directive in the schema #247

merged 5 commits into from
Jul 3, 2019

Conversation

dariuszkuc
Copy link
Collaborator

@dariuszkuc dariuszkuc commented Jul 1, 2019 •
edited
Loading

Resolves #246

@dariuszkuc dariuszkuc mentioned this pull request Jul 1, 2019
Closed
@dariuszkuc
Copy link
Collaborator Author

GraphQLSchema.print() extension prints the following
Screen Shot 2019-07-01 at 3 50 58 PM

smyrick
smyrick reviewed Jul 1, 2019
View reviewed changes
@codecov
Copy link

codecov bot commented Jul 1, 2019 •
edited
Loading

Codecov Report

Merging #247 into master will decrease coverage by 2.54%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #247      +/-   ##
============================================
- Coverage     96.87%   94.33%   -2.55%     
- Complexity      193      198       +5     
============================================
  Files            59       61       +2     
  Lines           641      688      +47     
  Branches        116      120       +4     
============================================
+ Hits            621      649      +28     
- Misses            9       28      +19     
  Partials         11       11
Impacted Files Coverage Δ Complexity Δ
...edia/graphql/extensions/GraphQLSchemaExtensions.kt 0% <0%> (ø) 0 <0> (?)
...expedia/graphql/generator/types/FunctionBuilder.kt 100% <100%> (ø) 13 <0> (ø) ⬇️
...com/expedia/graphql/generator/types/EnumBuilder.kt 100% <100%> (ø) 4 <0> (+1) ⬆️
...expedia/graphql/generator/types/PropertyBuilder.kt 100% <100%> (ø) 3 <0> (+1) ⬆️
...ia/graphql/generator/state/SchemaGeneratorState.kt 100% <100%> (ø) 6 <0> (ø) ⬇️
.../expedia/graphql/directives/DeprecatedDirective.kt 100% <100%> (ø) 0 <0> (?)
...graphql/directives/KotlinDirectiveWiringFactory.kt 93.54% <100%> (+4.65%) 15 <4> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d00b99...934c5ce. Read the comment docs.

dariuszkuc
dariuszkuc commented Jul 2, 2019
View reviewed changes
src/main/kotlin/com/expedia/graphql/extensions/GraphQLSchemaExtensions.kt Outdated
.includeExtendedScalarTypes(includeExtendedScalarTypes)
.includeIntrospectionTypes(includeIntrospectionTypes)
.includeSchemaDefintion(includeSchemaDefinition)
.includeDirectives(false)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh.... this flag removes both directive definitions as well as their target locations :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an issue here: graphql-java/graphql-java#1587

@smyrick smyrick added changes: minor Changes require a minor version type: enhancement New feature or request labels Jul 3, 2019
@smyrick smyrick merged commit 0d6bee7 into ExpediaGroup:master Jul 3, 2019
@dariuszkuc dariuszkuc deleted the deprecated_directive branch July 8, 2019 15:55
smyrick pushed a commit to smyrick/graphql-kotlin that referenced this pull request Sep 11, 2019
@dariuszkuc
Explicit support for deprecated directive in the schema (ExpediaGroup…
bb9f30b 
…#247)

* Explicit support for deprecated directive in the schema

* custom SDL printer

* customize schema print extension, fix unit tests and detekt

* add printer tests

* revert changes to GraphQLName
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
@dariuszkuc
Explicit support for deprecated directive in the schema (ExpediaGroup…
6994686 
…#247)

* Explicit support for deprecated directive in the schema

* custom SDL printer

* customize schema print extension, fix unit tests and detekt

* add printer tests

* revert changes to GraphQLName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smyrick smyrick smyrick approved these changes

Assignees
No one assigned
Labels
changes: minor Changes require a minor version type: enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated directive is missing from the schema
2 participants
@dariuszkuc @smyrick