Skip to content

Fix built-in directive print strings to include arguments #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2019
Merged

Fix built-in directive print strings to include arguments #256

merged 1 commit into from
Jul 18, 2019

Conversation

dariuszkuc
Copy link
Collaborator

No description provided.

@dariuszkuc dariuszkuc force-pushed the fix_printing_deprecated branch from 69ea918 to 521b269 Compare July 18, 2019 14:17
@codecov
Copy link

codecov bot commented Jul 18, 2019 •
edited
Loading

Codecov Report

Merging #256 into master will decrease coverage by 0.25%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #256      +/-   ##
============================================
- Coverage     97.07%   96.81%   -0.26%     
  Complexity      196      196              
============================================
  Files            61       61              
  Lines           684      691       +7     
  Branches        120      122       +2     
============================================
+ Hits            664      669       +5     
- Misses            8        9       +1     
- Partials         12       13       +1
Impacted Files Coverage Δ Complexity Δ
.../expedia/graphql/directives/DeprecatedDirective.kt 100% <100%> (ø) 0 <0> (ø) ⬇️
...edia/graphql/extensions/GraphQLSchemaExtensions.kt 89.28% <75%> (-5.96%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7206cc...521b269. Read the comment docs.

@gscheibel gscheibel merged commit 885def4 into ExpediaGroup:master Jul 18, 2019
@dariuszkuc dariuszkuc deleted the fix_printing_deprecated branch July 18, 2019 17:36
@smyrick smyrick added changes: patch Changes require a patch version type: bug Something isn't working labels Jul 18, 2019
smyrick pushed a commit to smyrick/graphql-kotlin that referenced this pull request Sep 11, 2019
@dariuszkuc
Fix built-in directive print strings to include arguments (ExpediaGro…
bf3a163 
…up#256)
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
@dariuszkuc
Fix built-in directive print strings to include arguments (ExpediaGro…
32d58d0 
…up#256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gscheibel gscheibel gscheibel approved these changes

Assignees
No one assigned
Labels
changes: patch Changes require a patch version type: bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dariuszkuc @gscheibel @smyrick