Skip to content

feat: allow renaming of properties and functions #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Jul 19, 2019

Fixes #248

Use @GraphQLName to set the name of fields in the schema, not just type names

Use @GraphQLName to set the name of fields in the schema, not just type names
@smyrick smyrick added type: enhancement New feature or request changes: minor Changes require a minor version labels Jul 19, 2019
@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #272 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #272      +/-   ##
============================================
+ Coverage     96.81%   96.82%   +0.01%     
  Complexity      196      196              
============================================
  Files            61       61              
  Lines           691      694       +3     
  Branches        122      124       +2     
============================================
+ Hits            669      672       +3     
  Misses            9        9              
  Partials         13       13
Impacted Files Coverage Δ Complexity Δ
...expedia/graphql/generator/types/FunctionBuilder.kt 100% <100%> (ø) 13 <0> (ø) ⬇️
...expedia/graphql/generator/types/PropertyBuilder.kt 100% <100%> (ø) 3 <0> (ø) ⬇️
...edia/graphql/generator/types/InputObjectBuilder.kt 100% <100%> (ø) 3 <0> (ø) ⬇️
...raphql/generator/extensions/kPropertyExtensions.kt 100% <100%> (ø) 0 <0> (ø) ⬇️
...raphql/generator/extensions/kCallableExtensions.kt 100% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cffd85...72f9da6. Read the comment docs.

@dariuszkuc dariuszkuc merged commit 4b9aa35 into ExpediaGroup:master Jul 19, 2019
@smyrick smyrick deleted the graphql-name-fields branch July 19, 2019 21:38
smyrick added a commit to smyrick/graphql-kotlin that referenced this pull request Sep 11, 2019
Use @GraphQLName to set the name of fields in the schema, not just type names
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Use @GraphQLName to set the name of fields in the schema, not just type names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: minor Changes require a minor version type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Support renaming of GraphQL fields
2 participants