Implementing federation spec #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarrier
reviewed
Jul 31, 2019
pcarrier
reviewed
Jul 31, 2019
...-federation/src/main/kotlin/com/expedia/graphql/federation/FederationSchemaGeneratorHooks.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
force-pushed
the
federation
branch
2 times, most recently
from
f5fac85 to
b175ada
Compare
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
============================================
+ Coverage 64.56% 68.15% +3.58%
- Complexity 194 263 +69
============================================
Files 103 115 +12
Lines 1064 1275 +211
Branches 152 196 +44
============================================
+ Hits 687 869 +182
- Misses 363 385 +22
- Partials 14 21 +7
Continue to review full report at Codecov.
|
…in-schema-generator to generate federated GraphQL schemas. Federated GraphQL architecture is an alternative to schema stitching approach that relies on declarative programming composition of schemas. graphql-kotlin-federation adds support for the following: new @key, @extends, @external, @requires and @provides directives new _FieldSet and _Any scalar types new _Entity union type of all federated types new _service query that returns _Service object with sdl field new _entity query that returns list of _Entity objects In order to generate federate schemas we have to annotate the underlying type with proper new directives and then use new toFederatedSchema function to build the schema (instead of toSchema function from graphql-kotlin-schema-generator). FederatedSchemaGeneratorHooks also require to specify FederatedTypeRegistry that holds a mapping between federated type names and their corresponding resolver. Those new FederatedTypeResolvers are used to instantiate the federated types based on the federated _entity query generated from the gateway. See: https://www.apollographql.com/docs/apollo-server/federation/introduction/ Resolves: ExpediaGroup#238
rickfast
approved these changes
Aug 12, 2019
gscheibel
approved these changes
Aug 12, 2019
| type _Service { | ||
| sdl: String! | ||
| } | ||
| ``` |
There was a problem hiding this comment.
could be interesting to default the type description and add a link to section in the spec.
People will keep getting confused by _Entity and _Service for a while
graphql-kotlin-federation/README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| #### Extended Service |
There was a problem hiding this comment.
Should precise which service ReviewService here I believe
| * class User( | ||
| * @property:ExternalDirective val userId: String, | ||
| * @property:ExternalDirective val name: String | ||
| * ) |
There was a problem hiding this comment.
Does it mean if we have a third property here it wouldn't be exposed in the graph?
There was a problem hiding this comment.
it would result in invalid schema
gscheibel
reviewed
Aug 12, 2019
| } | ||
|
|
||
| type Query { | ||
| _service: _Service |
There was a problem hiding this comment.
If the service is not "federate-able" should its SDL contain _service?
There was a problem hiding this comment.
yes -> #280 (comment)
smyrick
pushed a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Sep 11, 2019
* Create new graphql-kotlin-federation module that extends graphql-kotlin-schema-generator to generate federated GraphQL schemas. Federated GraphQL architecture is an alternative to schema stitching approach that relies on declarative programming composition of schemas. graphql-kotlin-federation adds support for the following: new @key, @extends, @external, @requires and @provides directives new _FieldSet and _Any scalar types new _Entity union type of all federated types new _service query that returns _Service object with sdl field new _entity query that returns list of _Entity objects In order to generate federate schemas we have to annotate the underlying type with proper new directives and then use new toFederatedSchema function to build the schema (instead of toSchema function from graphql-kotlin-schema-generator). FederatedSchemaGeneratorHooks also require to specify FederatedTypeRegistry that holds a mapping between federated type names and their corresponding resolver. Those new FederatedTypeResolvers are used to instantiate the federated types based on the federated _entity query generated from the gateway. See: https://www.apollographql.com/docs/apollo-server/federation/introduction/ Resolves: ExpediaGroup#238
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Create new graphql-kotlin-federation module that extends graphql-kotlin-schema-generator to generate federated GraphQL schemas. Federated GraphQL architecture is an alternative to schema stitching approach that relies on declarative programming composition of schemas. graphql-kotlin-federation adds support for the following: new @key, @extends, @external, @requires and @provides directives new _FieldSet and _Any scalar types new _Entity union type of all federated types new _service query that returns _Service object with sdl field new _entity query that returns list of _Entity objects In order to generate federate schemas we have to annotate the underlying type with proper new directives and then use new toFederatedSchema function to build the schema (instead of toSchema function from graphql-kotlin-schema-generator). FederatedSchemaGeneratorHooks also require to specify FederatedTypeRegistry that holds a mapping between federated type names and their corresponding resolver. Those new FederatedTypeResolvers are used to instantiate the federated types based on the federated _entity query generated from the gateway. See: https://www.apollographql.com/docs/apollo-server/federation/introduction/ Resolves: ExpediaGroup#238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new
graphql-kotlin-federationmodule that extendsgraphql-kotlin-schema-generatorto generate federated GraphQL schemas. Federated GraphQL architecture is an alternative to schema stitching approach that relies on declarative programming composition of schemas.graphql-kotlin-federationadds support for the following:@key,@extends,@external,@requiresand@providesdirectives_FieldSetand_Anyscalar types_Entityunion type of all federated types_servicequery that returns_Serviceobject withsdlfield_entityquery that returns list of_EntityobjectsIn order to generate federate schemas we have to annotate the underlying type with proper new directives and then use new
toFederatedSchemafunction to build the schema (instead oftoSchemafunction fromgraphql-kotlin-schema-generator).FederatedSchemaGeneratorHooksalso require to specifyFederatedTypeRegistrythat holds a mapping between federated type names and their corresponding resolver. Those newFederatedTypeResolvers are used to instantiate the federated types based on the federated_entityquery generated from the gateway.See: https://www.apollographql.com/docs/apollo-server/federation/introduction/
Resolves: #238