Fix type resolvers for renamed polymorphic types and fix hooks signature #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dariuszkuc
commented
Jul 26, 2019
dariuszkuc
commented
- devs can use @GraphQLName annotation to rename the underlying types - this change updates interface and union type resolvers to retrieve correct name when resolving the types
- update SchemaGeneratorHooks.didGenerateGraphQLType method to return the generated type instead of returning Unit, this makes it consistent with return type of other hook methods
* devs can use @GraphQLName annotation to rename the underlying types - this change updates interface and union type resolvers to retrieve correct name when resolving the types * update SchemaGeneratorHooks.didGenerateGraphQLType method to return the generated type instead of returning Unit, this makes it consistent with return type of other hook methods
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
============================================
- Coverage 96.82% 96.82% -0.01%
Complexity 196 196
============================================
Files 61 61
Lines 694 693 -1
Branches 124 124
============================================
- Hits 672 671 -1
Misses 9 9
Partials 13 13
Continue to review full report at Codecov.
|
smyrick
added
changes: major
smyrick
approved these changes
Jul 26, 2019
smyrick
pushed a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Sep 11, 2019
…ure (ExpediaGroup#282) * devs can use @GraphQLName annotation to rename the underlying types - this change updates interface and union type resolvers to retrieve correct name when resolving the types * update SchemaGeneratorHooks.didGenerateGraphQLType method to return the generated type instead of returning Unit, this makes it consistent with return type of other hook methods
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
…ure (ExpediaGroup#282) * devs can use @GraphQLName annotation to rename the underlying types - this change updates interface and union type resolvers to retrieve correct name when resolving the types * update SchemaGeneratorHooks.didGenerateGraphQLType method to return the generated type instead of returning Unit, this makes it consistent with return type of other hook methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.