fix: properly cache GraphQL object/interfaces/union types #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
============================================
- Coverage 64.69% 64.57% -0.13%
+ Complexity 198 195 -3
============================================
Files 103 103
Lines 1065 1067 +2
Branches 151 153 +2
============================================
Hits 689 689
- Misses 363 364 +1
- Partials 13 14 +1
Continue to review full report at Codecov.
|
`graphql-java` requires all `GraphQLObjectType`, `GraphQLInterfaceType` and `GraphQLUnionType` types to have unique names within a schema. While generating the schemas based on the reflections we have to ensure that each one of those objects is build only once. Since underlying objects do not implement hashcode it leads to problems if we attempt to update the fields through some hooks (e.g. use `newBuilder(existingObject)`). In order to make sure we only build those objects once we implemented basic caching logic in our builders - when we start building the target object we put it under construction and after it is build we add it to the cache and mark it completed. Unfortunately, existing logic was flawed - all objects were being put under construction but only `GraphQLObjectType`s generated when processing their `GraphQLInterfaceType` were marked as completed and added to the cache. This change fixes the caching logic to properly complete all `GraphQLObjectType`, `GraphQLInterfaceType` and `GraphQLUnionType` types and add them to the underlying cache.
smyrick
approved these changes
Aug 5, 2019
smyrick
added
changes: patch
smyrick
pushed a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Sep 11, 2019
…up#291) `graphql-java` requires all `GraphQLObjectType`, `GraphQLInterfaceType` and `GraphQLUnionType` types to have unique names within a schema. While generating the schemas based on the reflections we have to ensure that each one of those objects is build only once. Since underlying objects do not implement hashcode it leads to problems if we attempt to update the fields through some hooks (e.g. use `newBuilder(existingObject)`). In order to make sure we only build those objects once we implemented basic caching logic in our builders - when we start building the target object we put it under construction and after it is build we add it to the cache and mark it completed. Unfortunately, existing logic was flawed - all objects were being put under construction but only `GraphQLObjectType`s generated when processing their `GraphQLInterfaceType` were marked as completed and added to the cache. This change fixes the caching logic to properly complete all `GraphQLObjectType`, `GraphQLInterfaceType` and `GraphQLUnionType` types and add them to the underlying cache.
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
…up#291) `graphql-java` requires all `GraphQLObjectType`, `GraphQLInterfaceType` and `GraphQLUnionType` types to have unique names within a schema. While generating the schemas based on the reflections we have to ensure that each one of those objects is build only once. Since underlying objects do not implement hashcode it leads to problems if we attempt to update the fields through some hooks (e.g. use `newBuilder(existingObject)`). In order to make sure we only build those objects once we implemented basic caching logic in our builders - when we start building the target object we put it under construction and after it is build we add it to the cache and mark it completed. Unfortunately, existing logic was flawed - all objects were being put under construction but only `GraphQLObjectType`s generated when processing their `GraphQLInterfaceType` were marked as completed and added to the cache. This change fixes the caching logic to properly complete all `GraphQLObjectType`, `GraphQLInterfaceType` and `GraphQLUnionType` types and add them to the underlying cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql-javarequires allGraphQLObjectType,GraphQLInterfaceTypeandGraphQLUnionTypetypes to have unique names within a schema. While generating the schemas based on the reflections we have to ensure that each one of those objects is build only once. Since underlying objects do not implement hashcode it leads to problems if we attempt to update the fields through some hooks (e.g. usenewBuilder(existingObject)). In order to make sure we only build those objects once we implemented basic caching logic in our builders - when we start building the target object we put it under construction and after it is build we add it to the cache and mark it completed.Unfortunately, existing logic was flawed - all objects were being put under construction but only
GraphQLObjectTypes generated when processing theirGraphQLInterfaceTypewere marked as completed and added to the cache. This change fixes the caching logic to properly complete allGraphQLObjectType,GraphQLInterfaceTypeandGraphQLUnionTypetypes and add them to the underlying cache.