fix: allow modifying GraphQLInterfaceType in the willAddGraphQLTypeToSchema hook #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
force-pushed
the
fix_interface_hook
branch
from
877a45f to
09f9c3b
Compare
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
============================================
- Coverage 64.57% 64.56% -0.01%
+ Complexity 195 194 -1
============================================
Files 103 103
Lines 1067 1064 -3
Branches 153 152 -1
============================================
- Hits 689 687 -2
+ Misses 364 363 -1
Partials 14 14
Continue to review full report at Codecov.
|
…Schema hook InterfaceBuilder attempts to create all the implementing `GraphQLObjectType`s after building an interface but before executing the `willAddGraphQLTypeToSchema` hook. This means that if we attempt to update the interface in that hook there could be some objects implementing that interface and referencing the old one. Since graphql-java schema objects don't implement hashcode we end up with type conflict of two interfaces being defined in the schema. Fix is to use `GraphQLTypeReference` when referencing `GraphQLInterfaceType` from the `GraphQLObjectType` builder. Reference is just by name and they are resolved as the last step of building a schema. This allows us to modify the interface in the hook. Resolves: ExpediaGroup#281
dariuszkuc
force-pushed
the
fix_interface_hook
branch
from
09f9c3b to
4b6c3da
Compare
tapaderster
approved these changes
Aug 5, 2019
gscheibel
reviewed
Aug 5, 2019
| assertEquals("SomeData!", hooks.lastSeenGeneratedType?.deepName) | ||
| assertTrue(hooks.seenTypes.contains(RandomData::class.createType())) | ||
| assertTrue(hooks.seenTypes.contains(SomeData::class.createType())) | ||
| // TODO bug: didGenerateGraphQLType hook is not applied on the object types build from the interface |
There was a problem hiding this comment.
yes -> it is a bug in how we apply the hooks... :(
...otlin-schema-generator/src/test/kotlin/com/expedia/graphql/hooks/SchemaGeneratorHooksTest.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
force-pushed
the
fix_interface_hook
branch
from
eeea8b7 to
e0f50df
Compare
smyrick
pushed a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Sep 11, 2019
…Schema hook (ExpediaGroup#293) * fix: allow modifying GraphQLInterfaceType in the willAddGraphQLTypeToSchema hook InterfaceBuilder attempts to create all the implementing `GraphQLObjectType`s after building an interface but before executing the `willAddGraphQLTypeToSchema` hook. This means that if we attempt to update the interface in that hook there could be some objects implementing that interface and referencing the old one. Since graphql-java schema objects don't implement hashcode we end up with type conflict of two interfaces being defined in the schema. Fix is to use `GraphQLTypeReference` when referencing `GraphQLInterfaceType` from the `GraphQLObjectType` builder. Reference is just by name and they are resolved as the last step of building a schema. This allows us to modify the interface in the hook. Resolves: ExpediaGroup#281 * update test to verify hook updates interface description
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
…Schema hook (ExpediaGroup#293) * fix: allow modifying GraphQLInterfaceType in the willAddGraphQLTypeToSchema hook InterfaceBuilder attempts to create all the implementing `GraphQLObjectType`s after building an interface but before executing the `willAddGraphQLTypeToSchema` hook. This means that if we attempt to update the interface in that hook there could be some objects implementing that interface and referencing the old one. Since graphql-java schema objects don't implement hashcode we end up with type conflict of two interfaces being defined in the schema. Fix is to use `GraphQLTypeReference` when referencing `GraphQLInterfaceType` from the `GraphQLObjectType` builder. Reference is just by name and they are resolved as the last step of building a schema. This allows us to modify the interface in the hook. Resolves: ExpediaGroup#281 * update test to verify hook updates interface description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InterfaceBuilder attempts to create all the implementing
GraphQLObjectTypes after building an interface but before executing thewillAddGraphQLTypeToSchemahook. This means that if we attempt to update the interface in that hook there could be some objects implementing that interface and referencing the old one. Since graphql-java schema objects don't implement hashcode we end up with type conflict of two interfaces being defined in the schema.Fix is to use
GraphQLTypeReferencewhen referencingGraphQLInterfaceTypefrom theGraphQLObjectTypebuilder. Reference is just by name and they are resolved as the last step of building a schema. This allows us to modify the interface in the hook.Resolves: #281