Skip to content

chore: exclude the example app from code coverage #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Aug 12, 2019

Instead of deleting the tests, we can just exclude this project from the reports

This is the previous PR #290

Instead of deleting the tests, we can just exclude this project from the reports
@smyrick smyrick added the type: tool update CI, code coverage, or linter updates label Aug 12, 2019
@smyrick smyrick changed the title feat: exclude the example app from code coverage build: exclude the example app from code coverage Aug 12, 2019
@smyrick smyrick changed the title build: exclude the example app from code coverage chore: exclude the example app from code coverage Aug 12, 2019
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #297 into master will increase coverage by 26.12%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #297       +/-   ##
=============================================
+ Coverage     68.15%   94.27%   +26.12%     
+ Complexity      263      260        -3     
=============================================
  Files           115       73       -42     
  Lines          1275      909      -366     
  Branches        196      169       -27     
=============================================
- Hits            869      857       -12     
+ Misses          385       31      -354     
  Partials         21       21
Impacted Files Coverage Δ Complexity Δ
...a/graphql/sample/exceptions/ValidationException.kt
...m/expedia/graphql/sample/query/PolymorphicQuery.kt
...mple/directives/StringEvalSchemaDirectiveWiring.kt
...hql/sample/extension/CustomSchemaGeneratorHooks.kt
.../kotlin/com/expedia/graphql/sample/QueryHandler.kt
.../expedia/graphql/sample/mutation/WidgetMutation.kt
...in/kotlin/com/expedia/graphql/sample/model/Node.kt
...in/com/expedia/graphql/sample/query/WidgetQuery.kt
...pedia/graphql/sample/query/CustomDirectiveQuery.kt
...edia/graphql/sample/query/PrivateInterfaceQuery.kt
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdf961...0356195. Read the comment docs.

@smyrick
Copy link
Contributor Author

smyrick commented Aug 12, 2019

🎉 +26.12%

@smyrick smyrick merged commit c393bb4 into ExpediaGroup:master Aug 12, 2019
@smyrick smyrick deleted the code-cov-config branch August 12, 2019 19:53
smyrick added a commit to smyrick/graphql-kotlin that referenced this pull request Sep 11, 2019
Instead of deleting the tests, we can just exclude this project from the reports
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Instead of deleting the tests, we can just exclude this project from the reports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: tool update CI, code coverage, or linter updates
Development

Successfully merging this pull request may close these issues.

2 participants