Skip to content

Fix nested federation #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Sep 5, 2019

Fixes #310

While I don't think it is possible to have an input type extended we should still be able to have nested types that are not part of the federated entities be generated properly. This can happen when there are lists of nullalbes or double wrapped elements

Fixes ExpediaGroup#310

While I don't think it is possible to have an input type extended we should still be able to have nested types that are not part of the federated entities be generated properly. This can happen when there are lists of nullalbes or double wrapped elements
@smyrick smyrick added type: bug Something isn't working changes: patch Changes require a patch version labels Sep 5, 2019
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #316 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #316      +/-   ##
============================================
+ Coverage     93.59%   93.66%   +0.07%     
- Complexity      267      274       +7     
============================================
  Files            77       79       +2     
  Lines           968      979      +11     
  Branches        176      178       +2     
============================================
+ Hits            906      917      +11     
  Misses           36       36              
  Partials         26       26
Impacted Files Coverage Δ Complexity Δ
...phql/federation/execution/FederatedTypeRegistry.kt 100% <100%> (ø) 2 <1> (ø) ⬇️
...otlin/com/expedia/graphql/generator/TypeBuilder.kt 96.96% <100%> (ø) 20 <0> (ø) ⬇️
...expedia/graphql/generator/types/FunctionBuilder.kt 100% <0%> (ø) 8% <0%> (-2%) ⬇️
...xpedia/graphql/generator/types/DirectiveBuilder.kt 100% <0%> (ø) 10% <0%> (+2%) ⬆️
...edia/graphql/generator/types/InputObjectBuilder.kt 100% <0%> (ø) 2% <0%> (-1%) ⬇️
...raphql/generator/extensions/kPropertyExtensions.kt 100% <0%> (ø) 0% <0%> (ø) ⬇️
...expedia/graphql/generator/types/ArgumentBuilder.kt 100% <0%> (ø) 3% <0%> (?)
...ia/graphql/generator/types/InputPropertyBuilder.kt 100% <0%> (ø) 2% <0%> (?)
...n/com/expedia/graphql/generator/SchemaGenerator.kt 97.72% <0%> (+0.29%) 23% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a13e883...76b527b. Read the comment docs.

@dariuszkuc dariuszkuc merged commit 771b92a into ExpediaGroup:master Sep 6, 2019
@smyrick smyrick deleted the fix-nested-federation branch September 6, 2019 05:22
smyrick added a commit to smyrick/graphql-kotlin that referenced this pull request Sep 11, 2019
Fixes ExpediaGroup#310

While I don't think it is possible to have an input type extended we should still be able to have nested types that are not part of the federated entities be generated properly. This can happen when there are lists of nullalbes or double wrapped elements
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Fixes ExpediaGroup#310

While I don't think it is possible to have an input type extended we should still be able to have nested types that are not part of the federated entities be generated properly. This can happen when there are lists of nullalbes or double wrapped elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: patch Changes require a patch version type: bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Recursive relationships fail in Graphql Federation
2 participants