Fix bugs with generating arguments #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ExpediaGroup#249 Fixes ExpediaGroup#318 Resolve the two bugs and refactor the function to its own ArgumentBuilder so we can more easily test the bugs
smyrick
added
type: bug
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
============================================
- Coverage 93.59% 93.51% -0.09%
- Complexity 267 269 +2
============================================
Files 77 78 +1
Lines 968 971 +3
Branches 176 176
============================================
+ Hits 906 908 +2
Misses 36 36
- Partials 26 27 +1
Continue to review full report at Codecov.
|
dariuszkuc
approved these changes
Sep 5, 2019
smyrick
added a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Sep 11, 2019
Fixes ExpediaGroup#249 Fixes ExpediaGroup#318 Resolve the two bugs and refactor the function to its own ArgumentBuilder so we can more easily test the bugs
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Fixes ExpediaGroup#249 Fixes ExpediaGroup#318 Resolve the two bugs and refactor the function to its own ArgumentBuilder so we can more easily test the bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249
Fixes #318
Resolve the two bugs and refactor the function to its own ArgumentBuilder so we can more easily test the bugs