Skip to content

Directives on constructor args with no prefix #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Sep 5, 2019

Fixes #278

Property (input/output) directives are now resolved by checking the property and the constructor argument for any directives. This is the same pattern for checking any other annotations we have

Fixes ExpediaGroup#278

Property (input/output) directives are now resolved by checking the property and the constructor argument for any directives. This is the same pattern for checking any other annotations we have
@smyrick smyrick added type: bug Something isn't working changes: patch Changes require a patch version labels Sep 5, 2019
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #320 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #320      +/-   ##
============================================
+ Coverage     93.59%   93.64%   +0.05%     
- Complexity      267      272       +5     
============================================
  Files            77       78       +1     
  Lines           968      976       +8     
  Branches        176      178       +2     
============================================
+ Hits            906      914       +8     
  Misses           36       36              
  Partials         26       26
Impacted Files Coverage Δ Complexity Δ
...raphql/generator/extensions/kPropertyExtensions.kt 100% <100%> (ø) 0 <0> (ø) ⬇️
...ia/graphql/generator/types/InputPropertyBuilder.kt 100% <100%> (ø) 2 <2> (?)
...expedia/graphql/generator/types/PropertyBuilder.kt 100% <100%> (ø) 3 <0> (ø) ⬇️
...edia/graphql/generator/types/InputObjectBuilder.kt 100% <100%> (ø) 2 <0> (-1) ⬇️
...n/com/expedia/graphql/generator/SchemaGenerator.kt 97.61% <100%> (+0.18%) 22 <3> (+2) ⬆️
...xpedia/graphql/generator/types/DirectiveBuilder.kt 100% <100%> (ø) 10 <4> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a13e883...344b3fb. Read the comment docs.

@smyrick smyrick merged commit 0c87da3 into ExpediaGroup:master Sep 5, 2019
@smyrick smyrick deleted the directive-constructor-annotations branch September 5, 2019 17:03
smyrick added a commit to smyrick/graphql-kotlin that referenced this pull request Sep 11, 2019
Fixes ExpediaGroup#278

Property (input/output) directives are now resolved by checking the property and the constructor argument for any directives. This is the same pattern for checking any other annotations we have
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Fixes ExpediaGroup#278

Property (input/output) directives are now resolved by checking the property and the constructor argument for any directives. This is the same pattern for checking any other annotations we have
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: patch Changes require a patch version type: bug Something isn't working
Development

Successfully merging this pull request may close these issues.

directives on the constructor args require @property: prefix
2 participants