Skip to content

BREAKING CHANGE: Change to group id com.expediagroup #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Sep 6, 2019

Fixes #325

I will update the tokens in Travis before we release

Fixes ExpediaGroup#325

I will update the tokens in Travis before we merge
@smyrick smyrick added the changes: major Changes require a major version label Sep 6, 2019
@smyrick smyrick added this to the 1.0.0 milestone Sep 6, 2019
@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #326 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #326   +/-   ##
=========================================
  Coverage     93.66%   93.66%           
  Complexity      274      274           
=========================================
  Files            79       79           
  Lines           979      979           
  Branches        178      178           
=========================================
  Hits            917      917           
  Misses           36       36           
  Partials         26       26
Impacted Files Coverage Δ Complexity Δ
...expediagroup/graphql/generator/state/TypesCache.kt 100% <ø> (ø) 20 <0> (?)
...om/expediagroup/graphql/generator/SubTypeMapper.kt 100% <ø> (ø) 3 <0> (?)
...aphql/generator/extensions/kParameterExtensions.kt 100% <ø> (ø) 0 <0> (?)
...up/graphql/generator/state/SchemaGeneratorState.kt 100% <ø> (ø) 4 <0> (?)
...ediagroup/graphql/generator/state/TypesCacheKey.kt 100% <ø> (ø) 1 <0> (?)
.../graphql/generator/extensions/graphQLExtensions.kt 81.81% <ø> (ø) 0 <0> (?)
...agroup/graphql/generator/types/DirectiveBuilder.kt 100% <ø> (ø) 10 <0> (?)
...group/graphql/exceptions/GraphQLKotlinException.kt 100% <ø> (ø) 1 <0> (?)
...ediagroup/graphql/execution/FunctionDataFetcher.kt 86.95% <ø> (ø) 11 <0> (?)
...ediagroup/graphql/generator/types/ObjectBuilder.kt 94.73% <ø> (ø) 2 <0> (?)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1797a92...84951f8. Read the comment docs.

@smyrick smyrick merged commit 3149822 into ExpediaGroup:master Sep 6, 2019
@smyrick smyrick deleted the change-package-name branch September 6, 2019 18:41
smyrick added a commit to smyrick/graphql-kotlin that referenced this pull request Sep 11, 2019
Fixes ExpediaGroup#325

I will update the tokens in Travis before we merge
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Fixes ExpediaGroup#325

I will update the tokens in Travis before we merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: major Changes require a major version
Development

Successfully merging this pull request may close these issues.

Change the package name to com.expediagroup
3 participants