Skip to content

Add new module graphql-kotlin-spring-server #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 18, 2019

Conversation

dariuszkuc
Copy link
Collaborator

@dariuszkuc dariuszkuc commented Sep 7, 2019

Create a new module graphql-kotlin-spring-server which is a Spring Boot auto-configuration library for creating GraphQL web application.

@smyrick
Copy link
Contributor

smyrick commented Sep 8, 2019

Nice! This is exactly what I was talking about this week. I think it would be good even just for us to move more of this basic spring code to open source since everyone will have to do this same setup

I propose we call it graphql-kotlin-spring-server though since Spring Boot is just a library on top of Spring

@codecov-io
Copy link

codecov-io commented Sep 9, 2019

Codecov Report

Merging #329 into master will decrease coverage by 2.08%.
The diff coverage is 81.1%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #329      +/-   ##
============================================
- Coverage     96.82%   94.74%   -2.09%     
- Complexity      275      316      +41     
============================================
  Files            82       94      +12     
  Lines           977     1123     +146     
  Branches        182      203      +21     
============================================
+ Hits            946     1064     +118     
- Misses            6       20      +14     
- Partials         25       39      +14
Impacted Files Coverage Δ Complexity Δ
...aphql/spring/exception/SimpleKotlinGraphQLError.kt 22.22% <0%> (ø) 3 <1> (?)
...pediagroup/graphql/spring/model/GraphQLResponse.kt 71.42% <100%> (ø) 4 <1> (?)
...xpediagroup/graphql/spring/model/GraphQLRequest.kt 100% <100%> (ø) 4 <0> (?)
...roup/graphql/spring/FederationAutoConfiguration.kt 100% <100%> (ø) 4 <4> (?)
...p/graphql/spring/GraphQLConfigurationProperties.kt 100% <100%> (ø) 3 <3> (?)
...up/graphql/spring/SubscriptionAutoConfiguration.kt 100% <100%> (ø) 4 <4> (?)
...ing/exception/KotlinDataFetcherExceptionHandler.kt 25% <25%> (ø) 1 <1> (?)
...expediagroup/graphql/spring/RoutesConfiguration.kt 72% <72%> (ø) 11 <11> (?)
...in/com/expediagroup/graphql/spring/QueryHandler.kt 75% <75%> (ø) 0 <0> (?)
...iagroup/graphql/spring/GraphQLAutoConfiguration.kt 85.71% <85.71%> (ø) 4 <4> (?)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2955286...534acef. Read the comment docs.

@smyrick smyrick changed the title WIP: boot server WIP: graphql-kotlin-spring-server Sep 11, 2019
@smyrick
Copy link
Contributor

smyrick commented Sep 13, 2019

Looks good to me, ready for review by others?

@dariuszkuc dariuszkuc marked this pull request as ready for review September 13, 2019 20:24
@smyrick smyrick added changes: minor Changes require a minor version type: enhancement New feature or request labels Sep 13, 2019
@smyrick smyrick changed the title WIP: graphql-kotlin-spring-server Add new module graphql-kotlin-spring-server Sep 13, 2019
@smyrick
Copy link
Contributor

smyrick commented Sep 13, 2019

@dkuc84 It looks like you need to pull from master and update DataAndErrors.kt

@smyrick smyrick added this to the 1.0.0 milestone Sep 17, 2019
@smyrick smyrick merged commit 4a179f5 into ExpediaGroup:master Sep 18, 2019
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* WIP: boot server

* fix detekt

* fix unit test + copyright notice

* rename to graphql-kotlin-spring-server

* fix packages

* simplify package structure

* add unit tests

* include integration test in jacoco coverage calculation

* fix javadoc link

* subscription test

* Fix subscription unit tests

* additional unit tests

* subscription handler tests are actually integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: minor Changes require a minor version type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants