Skip to content

Increase code coverage #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Sep 8, 2019

Add more unit tests and remove duplicate default values to increase code coverage

Add more unit tests and remove duplicate default values to increase code coverage
@smyrick smyrick added the type: tool update CI, code coverage, or linter updates label Sep 8, 2019
@codecov-io
Copy link

codecov-io commented Sep 8, 2019

Codecov Report

Merging #331 into master will increase coverage by 0.7%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #331     +/-   ##
===========================================
+ Coverage     96.11%   96.82%   +0.7%     
- Complexity      274      278      +4     
===========================================
  Files            80       81      +1     
  Lines           979      976      -3     
  Branches        180      180             
===========================================
+ Hits            941      945      +4     
+ Misses           11        6      -5     
+ Partials         27       25      -2
Impacted Files Coverage Δ Complexity Δ
...hql/directives/KotlinSchemaDirectiveEnvironment.kt 93.33% <ø> (+24.91%) 13 <0> (+2) ⬆️
...iagroup/graphql/generator/types/FunctionBuilder.kt 100% <ø> (ø) 7 <0> (-1) ⬇️
.../expediagroup/graphql/generator/SchemaGenerator.kt 100% <ø> (+2.27%) 23 <0> (ø) ⬇️
...ediagroup/graphql/generator/types/ScalarBuilder.kt 100% <ø> (+4%) 7 <0> (ø) ⬇️
...phql/directives/KotlinFieldDirectiveEnvironment.kt 100% <100%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef94e70...4c1564d. Read the comment docs.

@dariuszkuc dariuszkuc merged commit 58d277c into ExpediaGroup:master Sep 9, 2019
@smyrick smyrick deleted the test-coverage branch September 9, 2019 05:45
smyrick added a commit to smyrick/graphql-kotlin that referenced this pull request Sep 11, 2019
Add more unit tests and remove duplicate default values to increase code coverage
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Add more unit tests and remove duplicate default values to increase code coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: tool update CI, code coverage, or linter updates
Development

Successfully merging this pull request may close these issues.

3 participants