spring server updates #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
force-pushed
the
spring_server
branch
from
7edb633 to
1ac514f
Compare
- update `GraphQLContextFactory` to use coroutines for building the context - extract `SubscriptionHandler` logic from default `WebSocketHandler`, default subscription `WebSocketHandler` will now call available `SubscriberHandler` bean - update `SimpleSubscriptionHandler` to use `GraphQLContext` - fixes ExpediaGroup#360 - add error handling to `SimpleSubscriptionHandler`
dariuszkuc
force-pushed
the
spring_server
branch
from
1ac514f to
3930cf9
Compare
ContextWebFilter returns a mono publisher that will compute the final result only after chain is subscribed to. StepVerifier was attempting to verify the context on the un-completed chain which did not populate the reactor context yet. Fix is to manually capture the context in the publisher chain, complete the publisher chain and then verify the contents of the captured reactor context.
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
============================================
- Coverage 94.69% 94.46% -0.23%
- Complexity 320 323 +3
============================================
Files 96 97 +1
Lines 1131 1139 +8
Branches 203 204 +1
============================================
+ Hits 1071 1076 +5
- Misses 21 22 +1
- Partials 39 41 +2
Continue to review full report at Codecov.
|
smyrick
approved these changes
Sep 20, 2019
smyrick
added
changes: minor
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* spring server updates - update `GraphQLContextFactory` to use coroutines for building the context - extract `SubscriptionHandler` logic from default `WebSocketHandler`, default subscription `WebSocketHandler` will now call available `SubscriberHandler` bean - update `SimpleSubscriptionHandler` to use `GraphQLContext` - fixes ExpediaGroup#360 - add error handling to `SimpleSubscriptionHandler` * fix context web filter test ContextWebFilter returns a mono publisher that will compute the final result only after chain is subscribed to. StepVerifier was attempting to verify the context on the un-completed chain which did not populate the reactor context yet. Fix is to manually capture the context in the publisher chain, complete the publisher chain and then verify the contents of the captured reactor context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
graphql-kotlin-spring-serverupdates:GraphQLContextFactoryto use coroutines for building the contextSubscriptionHandlerlogic from defaultWebSocketHandler, default subscriptionWebSocketHandlerwill now call availableSubscriberHandlerbeanSimpleSubscriptionHandlerto useGraphQLContext- fixes GraphQLContext unavailable for Subscriptions #360SimpleSubscriptionHandler🔗 Related Issues
#360