-
Notifications
You must be signed in to change notification settings - Fork 362
Fix Apollo subscription message handling #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
smyrick
merged 4 commits into
ExpediaGroup:master
from
smyrick:kotlin-flow-subscriptions
Sep 24, 2019
Merged
Fix Apollo subscription message handling #371
smyrick
merged 4 commits into
ExpediaGroup:master
from
smyrick:kotlin-flow-subscriptions
Sep 24, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two examples of sending the Keep alive message and |
dariuszkuc
reviewed
Sep 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
===========================================
- Coverage 94.38% 94.28% -0.1%
- Complexity 323 338 +15
===========================================
Files 97 99 +2
Lines 1139 1207 +68
Branches 204 213 +9
===========================================
+ Hits 1075 1138 +63
- Misses 22 26 +4
- Partials 42 43 +1
Continue to review full report at Codecov.
|
dariuszkuc
reviewed
Sep 24, 2019
...ing-server/src/main/kotlin/com/expediagroup/graphql/spring/GraphQLConfigurationProperties.kt
Show resolved
Hide resolved
The config value for the packages is overriden in the hooks so we can remove it
dariuszkuc
approved these changes
Sep 24, 2019
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Fix Apollo subscription message handling * Implement graphql-ws spec Here is the spec https://github.com/apollographql/subscriptions-transport-ws/blob/master/PROTOCOL.md * update spring config metadata * Remove unused config The config value for the packages is overriden in the hooks so we can remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Support the messages that come from the Apollo client subscriptions.
https://github.com/apollographql/subscriptions-transport-ws/blob/master/PROTOCOL.md
We need to wrap the GraphQLRequest and GraphQLResponse in a special message before we send it over the web socket. That message structure is implemented in the handler for the
graphql-ws
protocol🔗 Related Issues
Fixes #370