Upgrade library versions and unit tests #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2019 12:43
One last bump of unit test coverage and update our dependencies before the 1.0.0 release
smyrick
added
changes: patch
smyrick
commented
Sep 25, 2019
| // [OK] @provides references list of valid @extend objects | ||
| // [ERROR] @provides references @external list field | ||
| // [ERROR] @provides references @external interface field | ||
| private fun validateProvidesDirective(federatedType: String, field: GraphQLFieldDefinition): List<String> { |
There was a problem hiding this comment.
Just moved these functions to their own internal files so we can more easily scope the unit tests
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
===========================================
+ Coverage 95.76% 97.67% +1.9%
+ Complexity 347 316 -31
===========================================
Files 98 104 +6
Lines 1205 1204 -1
Branches 213 198 -15
===========================================
+ Hits 1154 1176 +22
+ Misses 11 9 -2
+ Partials 40 19 -21
Continue to review full report at Codecov.
|
dariuszkuc
reviewed
Sep 25, 2019
dariuszkuc
approved these changes
Sep 25, 2019
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Upgrade library versions and unit tests One last bump of unit test coverage and update our dependencies before the 1.0.0 release * Update other versions * Fix build for jdk8 * Update coroutines version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
One last bump of unit test coverage and update our dependencies before the 1.0.0 release