Skip to content

Make FederatedSchemaGenerator open #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Make FederatedSchemaGenerator open #385

merged 1 commit into from
Sep 27, 2019

Conversation

de55
Copy link
Contributor

@de55 de55 commented Sep 27, 2019

📝 Description

Open FederatedSchemaGenerator so that it can be inherited from.

🔗 Related Issues

#384

@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #385 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #385   +/-   ##
=========================================
  Coverage     97.61%   97.61%           
  Complexity      318      318           
=========================================
  Files           104      104           
  Lines          1217     1217           
  Branches        198      198           
=========================================
  Hits           1188     1188           
  Misses            9        9           
  Partials         20       20
Impacted Files Coverage Δ Complexity Δ
...oup/graphql/federation/FederatedSchemaGenerator.kt 100% <100%> (ø) 4 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af202f0...011fac7. Read the comment docs.

@dariuszkuc dariuszkuc merged commit 41524f4 into ExpediaGroup:master Sep 27, 2019
@smyrick smyrick added changes: minor Changes require a minor version type: enhancement New feature or request labels Sep 27, 2019
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: minor Changes require a minor version type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants