Skip to content

[spring-server] SimplQueryHandler support for DataLoaderRegistry #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

dariuszkuc
Copy link
Collaborator

📝 Description

When creating new ExecutionInput we should automatically register DataLoaderRegistry if it is present in the application context.

🔗 Related Issues

#381
#396

When creating new `ExecutionInput` we should automatically register `DataLoaderRegistry` if it is present in the application context.
@smyrick smyrick added changes: minor Changes require a minor version type: enhancement New feature or request labels Sep 30, 2019
@dariuszkuc dariuszkuc merged commit 41df336 into ExpediaGroup:master Sep 30, 2019
@dariuszkuc dariuszkuc deleted the data_loader branch September 30, 2019 17:22
@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #400 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #400      +/-   ##
===========================================
+ Coverage     97.71%   97.8%   +0.08%     
- Complexity      324     325       +1     
===========================================
  Files           104     104              
  Lines          1226    1228       +2     
  Branches        199     200       +1     
===========================================
+ Hits           1198    1201       +3     
+ Misses            8       7       -1     
  Partials         20      20
Impacted Files Coverage Δ Complexity Δ
...pediagroup/graphql/spring/model/GraphQLResponse.kt 100% <ø> (ø) 4 <0> (ø) ⬇️
...iagroup/graphql/spring/GraphQLAutoConfiguration.kt 90% <100%> (+0.52%) 7 <0> (+1) ⬆️
...ediagroup/graphql/spring/execution/QueryHandler.kt 90.9% <100%> (ø) 0 <0> (ø) ⬇️
...xpediagroup/graphql/spring/model/GraphQLRequest.kt 100% <100%> (+9.09%) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f96fc4e...6878f08. Read the comment docs.

dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
…ediaGroup#400)

When creating new `ExecutionInput` we should automatically register `DataLoaderRegistry` if it is present in the application context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: minor Changes require a minor version type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants