[federation] fix: SDL should be generated for non-federated schemas #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Federated GraphQL gateway can contain number of services that are not exposing any of their types as federated types (i.e. without exposing any of them using @key directives). We were incorrectly generating SDL only if there were some federated types in the generated schema. Fix is to always generated the SDL.
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
========================================
Coverage 97.8% 97.8%
Complexity 325 325
========================================
Files 105 105
Lines 1228 1228
Branches 202 202
========================================
Hits 1201 1201
Misses 7 7
Partials 20 20
Continue to review full report at Codecov.
|
smyrick
approved these changes
Oct 2, 2019
smyrick
added
changes: patch
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
…xpediaGroup#417) Federated GraphQL gateway can contain number of services that are not exposing any of their types as federated types (i.e. without exposing any of them using @key directives). We were incorrectly generating SDL only if there were some federated types in the generated schema. Fix is to always generated the SDL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Federated GraphQL gateway can contain number of services that are not exposing any of their types as federated types (i.e. without exposing any of them using @key directives). We were incorrectly generating SDL only if there were some federated types in the generated schema. Fix is to always generated the SDL.
🔗 Related Issues
Resolves #416