[spring-server] fix: Exclude stacktraces when null values are specified for non-null parameters #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
============================================
+ Coverage 97.8% 97.81% +0.01%
Complexity 325 325
============================================
Files 105 105
Lines 1230 1236 +6
Branches 202 204 +2
============================================
+ Hits 1203 1209 +6
Misses 7 7
Partials 20 20
Continue to review full report at Codecov.
|
dariuszkuc
reviewed
Oct 14, 2019
...otlin-spring-server/src/main/kotlin/com/expediagroup/graphql/spring/model/GraphQLResponse.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
requested changes
Oct 14, 2019
...otlin-spring-server/src/main/kotlin/com/expediagroup/graphql/spring/model/GraphQLResponse.kt
Show resolved
Hide resolved
smyrick
reviewed
Oct 15, 2019
smyrick
approved these changes
Oct 16, 2019
smyrick
suggested changes
Oct 16, 2019
@smyrick I think we do have one already for the default behavior - https://github.com/ExpediaGroup/graphql-kotlin/blob/master/graphql-kotlin-spring-server/src/test/kotlin/com/expediagroup/graphql/spring/model/GraphQLResponseKtTest.kt#L75 |
dariuszkuc
approved these changes
Oct 16, 2019
smyrick
approved these changes
Oct 16, 2019
smyrick
added
changes: patch
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Refer #423 (comment) for the cause
The fix includes setting
stackTraceto an empty array when the error type is aValidationErrorand aNonNullableValueCoercedAsNullExceptionwas thrown🔗 Related Issues
Resolves #423