Skip to content

[spring-server] use data classes for configuration properties #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

dariuszkuc
Copy link
Collaborator

📝 Description

SpringBoot 2.2 supports using immutable data classes for ConfigurationProperties by specifying @ConstructorBinding.

🔗 Related Issues

SpringBoot 2.2 supports using immutable data classes for `ConfigurationProperties` by specifying `@ConstructorBinding`.
@dariuszkuc dariuszkuc added changes: patch Changes require a patch version type: refactor Code changes that have no impact on users labels Oct 18, 2019
@dariuszkuc
Copy link
Collaborator Author

Also cleaned up example app configs due to #433

@codecov-io
Copy link

codecov-io commented Oct 18, 2019

Codecov Report

Merging #445 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #445   +/-   ##
=========================================
  Coverage     97.92%   97.92%           
- Complexity      325      326    +1     
=========================================
  Files           106      106           
  Lines          1254     1254           
  Branches        206      206           
=========================================
  Hits           1228     1228           
  Misses            7        7           
  Partials         19       19
Impacted Files Coverage Δ Complexity Δ
...p/graphql/spring/GraphQLConfigurationProperties.kt 100% <100%> (ø) 5 <5> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a305247...1afac0c. Read the comment docs.

Copy link
Contributor

@smyrick smyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@smyrick smyrick merged commit 99e1749 into ExpediaGroup:master Oct 18, 2019
@dariuszkuc dariuszkuc deleted the configuration_properties branch October 18, 2019 16:14
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
…aGroup#445)

SpringBoot 2.2 supports using immutable data classes for `ConfigurationProperties` by specifying `@ConstructorBinding`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: patch Changes require a patch version type: refactor Code changes that have no impact on users
Development

Successfully merging this pull request may close these issues.

3 participants