Allow updating custom additional types #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As dicussed in other PRs ExpediaGroup#587 and ExpediaGroup#585 we can allow developers to have more customization of the schema by allowing them to add additional types of their own without having to add it to the schema directly. What they do with this feature will be up to them, but from a libray perspective it is not bad feature to support.
smyrick
added
type: enhancement
|
Actually this may not allow for someone to override the Do we instead need to make this method |
|
Yes. In order to allow easy extension |
dariuszkuc
approved these changes
Feb 3, 2020
|
Does this need an updated doc or sample? |
|
@EXPErdelfavero Yes, it does. Thank you for keep on top of that for us. We need to get better at checking docs, especially if there is a new feature label. |
smyrick
pushed a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Feb 3, 2020
Added new features in ExpediaGroup#593 that we did not document
dariuszkuc
pushed a commit
that referenced
this pull request
Feb 7, 2020
Added new features in #593 that we did not document
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Allow updating custom additional types As dicussed in other PRs ExpediaGroup#587 and ExpediaGroup#585 we can allow developers to have more customization of the schema by allowing them to add additional types of their own without having to add it to the schema directly. What they do with this feature will be up to them, but from a libray perspective it is not bad feature to support. * Make function open
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Added new features in ExpediaGroup#593 that we did not document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
As discussed in other PRs #587 and #585 we can allow developers to have more customization of the schema by allowing them to add additional types of their own without having to add it to the schema directly. What they do with this feature will be up to them, but from a library perspective it is not bad feature to support.
🔗 Related Issues
See my comment here for more details: #585 (comment)