Refactor to remove build warnings #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2020 13:31
Non-functional change that just adds some internal documentation and cleans up some build and IDE warnings
smyrick
added
changes: patch
Warning was valid - reading body is a blocking operation. Moving this code around doesn't change this. Personally I am also unsure whether the new refactored version of |
dariuszkuc
reviewed
Feb 24, 2020
...c/main/kotlin/com/expediagroup/graphql/spring/execution/ApolloSubscriptionProtocolHandler.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
reviewed
Feb 24, 2020
.../src/test/kotlin/com/expediagroup/graphql/spring/routes/SubscriptionRoutesConfigurationIT.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
approved these changes
Feb 29, 2020
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Refactor to clean up some build warnings Non-functional change that just adds some internal documentation and cleans up some build and IDE warnings * Suppress unused wanrings in tests * Undo RouteConfiguration changes * Move strings to const * Move constants to internal file reference * Remove unessacary function calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Refactor library and test code to remove some build and IDE warnings. This is a non-functional change.
🔗 Related Issues
N\A