[generator] Fix issue generating nested additional types #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would encounter a bug if generating the additional types producded more additional types. So we now call the function recursively and clear it out before generating more.
smyrick
added
type: bug
dariuszkuc
reviewed
Feb 26, 2020
...otlin-schema-generator/src/main/kotlin/com/expediagroup/graphql/generator/SchemaGenerator.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
reviewed
Feb 26, 2020
...otlin-schema-generator/src/main/kotlin/com/expediagroup/graphql/generator/SchemaGenerator.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
reviewed
Feb 26, 2020
...otlin-schema-generator/src/main/kotlin/com/expediagroup/graphql/generator/SchemaGenerator.kt
Outdated
Show resolved
Hide resolved
Co-Authored-By: Dariusz Kuc <[email protected]>
dariuszkuc
approved these changes
Feb 26, 2020
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
…p#615) * Fix issue generating nested additional types We would encounter a bug if generating the additional types producded more additional types. So we now call the function recursively and clear it out before generating more. * Apply suggestions from code review Co-Authored-By: Dariusz Kuc <[email protected]> * Reverse addition order Co-authored-by: Dariusz Kuc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
We would encounter a bug if generating the additional types produced more additional types. So we now call the function recursively and clear it out before generating more.
🔗 Related Issues
N\A