move generation of additional types to an iterative approach #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapaderster
added
type: refactor
smyrick
approved these changes
Feb 26, 2020
dariuszkuc
reviewed
Feb 26, 2020
| val graphqlTypes = currentlyProcessedTypes.map { generateGraphQLType(this, it) }.toSet() | ||
| val currentlyProcessedTypes = mutableSetOf<KType>() | ||
| val graphqlTypes = mutableSetOf<GraphQLType>() | ||
| do { |
There was a problem hiding this comment.
i think you want to use while loop instead of do as additional types could be empty
There was a problem hiding this comment.
Whoops, merged to fast. Yes it would execute the first time, it would iterate over an empty set so not doing to much, but a while could be clearer
dariuszkuc
reviewed
Feb 26, 2020
| currentlyProcessedTypes.addAll(this.additionalTypes) | ||
| this.additionalTypes.clear() | ||
| graphqlTypes.addAll(currentlyProcessedTypes.map { generateGraphQLType(this, it) }) | ||
| currentlyProcessedTypes.clear() |
There was a problem hiding this comment.
is constantly clearing the same object better than recreating the hash set?, e.g.
val graphqlTypes = mutableSetOf<GraphQLType>()
while (this.additionalTypes.isNotEmpty()) {
val currentlyProcessedTypes = HashSet(this.additionalTypes)
this.additionalTypes.clear()
graphqlTypes.addAll(currentlyProcessedTypes.map { generateGraphQLType(this, it) })
}
return graphqlTypes.toSet()
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Changed the current recursive approach of adding the additional types to iterative one.
This approach saves:
toSet()calls which internally means creation of new LinkedHashSet.plus()calls which also creates a new LinkedHashSet and does anaddAll()internally.