Upgrade springboot to fix security issue #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring Boot 2.2.5 was released which includes a fix for a security issue in netty. See: https://spring.io/blog/2020/02/27/spring-boot-2-2-5-released
smyrick
added
changes: patch
dariuszkuc
reviewed
Feb 28, 2020
| @@ -5,7 +5,7 @@ val graphQLJavaVersion: String by project | |||
| val jacksonVersion: String by project | |||
| val kotlinVersion: String by project | |||
| val kotlinCoroutinesVersion: String by project | |||
| val rxjavaVersion = "3.0.0" | |||
| val rxjavaVersion: String by project | |||
There was a problem hiding this comment.
maybe we should update our tests to create custom Reactor Monad and drop RxJava altogether?
There was a problem hiding this comment.
*just a side note for future
There was a problem hiding this comment.
If we have it as an official example in our documentation I like having it included in our test dependencies.
But as you mentioned we could just edit our docs and examples to just use reactor/spring wrappers and comment that they can work for any custom wrappers you want to include
Let's make that a separate PR
dariuszkuc
approved these changes
Feb 28, 2020
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Spring Boot 2.2.5 was released which includes a fix for a security issue in netty. See: https://spring.io/blog/2020/02/27/spring-boot-2-2-5-released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Spring Boot 2.2.5 was released which includes a fix for a security issue in netty. See: https://spring.io/blog/2020/02/27/spring-boot-2-2-5-released
🔗 Related Issues
Fixes #625