Update dependencies and gradle config #640
Conversation
Include certain dependencies as implementation instead of api so that they are not exposed by default. If you want to use coroutine in your GraphQL API you will need to also include the library
smyrick
added
changes: patch
| @@ -14,8 +14,8 @@ dependencies { | |||
| api(project(path = ":graphql-kotlin-federation")) | |||
| api("org.springframework.boot:spring-boot-starter-webflux:$springBootVersion") | |||
| kapt("org.springframework.boot:spring-boot-configuration-processor:$springBootVersion") | |||
| api("io.projectreactor.kotlin:reactor-kotlin-extensions:$reactorExtensionsVersion") | |||
| api("org.jetbrains.kotlinx:kotlinx-coroutines-reactor:$kotlinCoroutinesVersion") | |||
| implementation("io.projectreactor.kotlin:reactor-kotlin-extensions:$reactorExtensionsVersion") | |||
There was a problem hiding this comment.
I think that spring-server as SpringBoot autoconfiguration library should pull in all the required dependencies including both Reactor and Coroutines.
There was a problem hiding this comment.
We can exposes coroutines as an api dependency but I don't think we need to expose the reactor and kotlin extensions, right?
You don't explicitly need to use those to use graphql-kotlin-spring-server.
Or do we just want to include them for convenience?
There was a problem hiding this comment.
i believe SpringBoot pulls in reactor so adding api dependency on coroutines should be fine
There was a problem hiding this comment.
We do use these in the example apps, so we could make them api or do we want to update the example apps to pull in the extensions as well?
There was a problem hiding this comment.
Let's keep them as api deps for now.
* Update dependencies and gradle config Include certain dependencies as implementation instead of api so that they are not exposed by default. If you want to use coroutine in your GraphQL API you will need to also include the library * Include coroutines in graphql-kotlin-spring-server as api dep * Include coroutines as implementation dep on all modules * Move deps to api for spring server * Remove unused gradle props Co-authored-by: Shane Myrick <[email protected]>
📝 Description
Include certain dependencies as implementation instead of api so that they are not exposed by default. If you want to use coroutine in your GraphQL API you will need to also include the library
🔗 Related Issues