Reuse schema generator for tests #641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrick
added
changes: patch
smyrick
commented
Mar 18, 2020
| @@ -67,7 +67,7 @@ open class SchemaGenerator(internal val config: SchemaGeneratorConfig) { | |||
| builder.codeRegistry(codeRegistry.build()) | |||
| val schema = config.hooks.willBuildSchema(builder).build() | |||
|
|
|||
| classScanner.close() | |||
There was a problem hiding this comment.
This will be closed automatically when the schema generator is removed by GC
There was a problem hiding this comment.
i'd still explicitly close it just in case
There was a problem hiding this comment.
since ScanResult implements Closeable we could use Kotlin use (https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.io/use.html)
|
I have no idea why these checks are not failing for me locally. I keep running a build on java 11 but it is always passing for me |
added 3 commits
March 19, 2020 11:29
In an effort to save memory and build time, I made a common testGenerator that just uses the basic SchemaGeneratorConfig we already we using. Previously, every call to toSchema would create a new SchemaGenerator class which creates a new type cache and class scanner. Maybe this will help with the Github actions?
smyrick
force-pushed
the
reuse-schema-generator
branch
from
def109b to
ce6360b
Compare
smyrick
pushed a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Mar 19, 2020
Extracting separate changes from ExpediaGroup#641 that cleans up the resources used when creating a new schema generator. Hopefully this will help with our unit test out of memory issues
|
Closing in favor of #643 |
dariuszkuc
pushed a commit
that referenced
this pull request
Mar 20, 2020
Extracting separate changes from #641 that cleans up the resources used when creating a new schema generator. Hopefully this will help with our unit test out of memory issues Co-authored-by: Shane Myrick <[email protected]>
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Extracting separate changes from ExpediaGroup#641 that cleans up the resources used when creating a new schema generator. Hopefully this will help with our unit test out of memory issues Co-authored-by: Shane Myrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
In an effort to save memory and build time, I made a common testGenerator that just uses the basic SchemaGeneratorConfig we already we using. Previously, every call to toSchema would create a new SchemaGenerator class which creates a new type cache and class scanner. Maybe this will help with the Github actions out of memory issues?
🔗 Related Issues