chore: reduce complexity of getConfig fn

Signed-off-by: Jakub Freisler <[email protected]>

Author: FRSgit

packages/cypress-plugin-visual-regression-diff/src/commands.ts

@@ -62,11 +62,27 @@ const constructCypressError = (log: Cypress.Log, err: Error) => {
 const capitalize = (text: string) =>
   text.charAt(0).toUpperCase() + text.slice(1);
 
-const getPluginEnv = <R extends keyof Cypress.MatchImageOptions>(key: R) =>
+const getPluginEnv = <K extends keyof Cypress.MatchImageOptions>(key: K) =>
   Cypress.env(`pluginVisualRegression${capitalize(key)}`) as
-    | Cypress.MatchImageOptions[R]
+    | Cypress.MatchImageOptions[K]
     | undefined;
 
+const booleanOption = <K extends keyof Cypress.MatchImageOptions, Return>(
+  options: Cypress.MatchImageOptions,
+  key: K,
+  truthyValue: Return,
+  falsyValue: Return
+) =>
+  options[key] === false || getPluginEnv(key) === false
+    ? truthyValue
+    : falsyValue;
+
+const optionWithDefaults = <K extends keyof Cypress.MatchImageOptions>(
+  options: Cypress.MatchImageOptions,
+  key: K,
+  defaultValue: NonNullable<Cypress.MatchImageOptions[K]>
+) => options[key] ?? getPluginEnv(key) ?? defaultValue;
+
 const getImagesDir = (options: Cypress.MatchImageOptions) => {
   const imagesDir = options.imagesDir || getPluginEnv("imagesDir");
 
@@ -80,34 +96,31 @@ const getImagesDir = (options: Cypress.MatchImageOptions) => {
   return imagesDir;
 };
 
-export const getConfig = (options: Cypress.MatchImageOptions) => {
+const getImagesPath = (options: Cypress.MatchImageOptions) => {
   const imagesDir = getImagesDir(options);
 
-  return {
-    scaleFactor:
-      options.forceDeviceScaleFactor === false ||
-      getPluginEnv("forceDeviceScaleFactor") === false
-        ? 1
-        : 1 / window.devicePixelRatio,
-    createMissingImages:
-      options.createMissingImages ??
-      getPluginEnv("createMissingImages") ??
-      true,
-    updateImages: options.updateImages ?? getPluginEnv("updateImages") ?? false,
-    imagesPath:
-      (imagesDir && `{spec_path}/${imagesDir}`) ||
-      options.imagesPath ||
-      getPluginEnv("imagesPath") ||
-      "{spec_path}/__image_snapshots__",
-    maxDiffThreshold:
-      options.maxDiffThreshold ?? getPluginEnv("maxDiffThreshold") ?? 0.01,
-    diffConfig: options.diffConfig || getPluginEnv("diffConfig") || {},
-    screenshotConfig:
-      options.screenshotConfig || getPluginEnv("screenshotConfig") || {},
-    matchAgainstPath: options.matchAgainstPath || undefined,
-  };
+  return (
+    (imagesDir && `{spec_path}/${imagesDir}`) ||
+    optionWithDefaults(options, "imagesPath", "{spec_path}/__image_snapshots__")
+  );
 };
 
+export const getConfig = (options: Cypress.MatchImageOptions) => ({
+  scaleFactor: booleanOption(
+    options,
+    "forceDeviceScaleFactor",
+    1,
+    1 / window.devicePixelRatio
+  ),
+  createMissingImages: optionWithDefaults(options, "createMissingImages", true),
+  updateImages: optionWithDefaults(options, "updateImages", false),
+  imagesPath: getImagesPath(options),
+  maxDiffThreshold: optionWithDefaults(options, "maxDiffThreshold", 0.01),
+  diffConfig: optionWithDefaults(options, "diffConfig", {}),
+  screenshotConfig: optionWithDefaults(options, "screenshotConfig", {}),
+  matchAgainstPath: options.matchAgainstPath || undefined,
+});
+
 Cypress.Commands.add(
   "matchImage",
   { prevSubject: "optional" },