Skip to content

docs: update README.md to clarify plugin loading #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

byronwall
Copy link
Contributor

Clarify plugin loading process when running as a component instead of e2e.

The example project does a good job of showing the initPlugin call in both e2e and component objects. Unfortunately, I did not notice that until I was 30 minutes past spotting the obvious. Clarifying the README might help another lost dev.

Clarify plugin loading process when running as a `component` instead of `e2e`.

The `example` project does a good job of showing the `initPlugin` call in both `e2e` and `component` objects.  Unfortunately, I did not notice that until I was 30 minutes past spotting the obvious.  Clarifying the README might help another lost dev.
@FRSgit FRSgit self-requested a review September 26, 2022 13:26
@FRSgit FRSgit added the documentation Improvements or additions to documentation label Sep 26, 2022
@FRSgit
Copy link
Member

FRSgit commented Sep 26, 2022

Hi @byronwall!

You're right, I was struggling with that myself at the beginning, but forgot to point it out in the README later on 🤦
Sorry for your wasted time and thank you for this catch - it will surely help others in the future 😄
I'm merging this PR right away!

@FRSgit FRSgit changed the title docs: updateREADME.md to clarify plugin loading docs: update README.md to clarify plugin loading Sep 26, 2022
@FRSgit FRSgit merged commit 886cd5d into FRSOURCE:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants