Skip to content

Address feedback from the bug bash #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Aug 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
6bccb71
Fix up angular, root cause was that defaultProject is now gone
jamesdaniels Jul 18, 2022
6410290
Moving over to ESM
jamesdaniels Jul 18, 2022
9024bc0
Bump functions
jamesdaniels Jul 18, 2022
3702860
Flushing out tests more
jamesdaniels Jul 18, 2022
ec2c23b
Dev on actions
jamesdaniels Jul 18, 2022
fc45491
Node 16/18
jamesdaniels Jul 18, 2022
6034b2c
Mark engines as Node 16 and 18
jamesdaniels Jul 18, 2022
d02de2f
Drop Node 18
jamesdaniels Jul 19, 2022
5197dc2
Build in test file, output debug log
jamesdaniels Jul 19, 2022
03b9315
Try file://, cleanup tests
jamesdaniels Jul 19, 2022
bda9fea
nvm
jamesdaniels Jul 19, 2022
a225f71
pathToFileURL
jamesdaniels Jul 19, 2022
bdc8494
ESM & codegen, oh my!
jamesdaniels Jul 19, 2022
445d119
More pathToFileUrls
jamesdaniels Jul 19, 2022
c887454
More pathToFileURL
jamesdaniels Jul 19, 2022
328ac19
Express/custom/angular should work with ESM
jamesdaniels Jul 26, 2022
5f5b150
Overrides, build fixes, and autoinit oh my!
jamesdaniels Aug 12, 2022
b9a1683
Version
jamesdaniels Aug 12, 2022
3b38fc2
Drop unused stuff from build
jamesdaniels Aug 12, 2022
3ffee20
Only iterate over overrides if they exist, fix build
jamesdaniels Aug 15, 2022
b5c0098
Enable minimal mode
jamesdaniels Aug 15, 2022
c3e37bc
Rearranging framework detection, custom to the top
jamesdaniels Aug 15, 2022
ed6cb76
Drop the client
jamesdaniels Aug 15, 2022
71bc227
Bump firebase
jamesdaniels Aug 15, 2022
90f125e
Investigate but these are broken on CI
jamesdaniels Aug 15, 2022
63fcfe8
Drop client from the package.json
jamesdaniels Aug 15, 2022
70aa716
Fixing relative path for angular apps
jamesdaniels Aug 15, 2022
1fc3580
Fix relative path for prerender
jamesdaniels Aug 15, 2022
9e9b031
Directories for windows
jamesdaniels Aug 15, 2022
8c93ae1
Better detect unrendered pages
jamesdaniels Aug 16, 2022
e30071c
Try spawn without .bin
jamesdaniels Aug 16, 2022
41ace0e
Try npm.cmd
jamesdaniels Aug 16, 2022
fd7905e
Return express framework in dynamicImport...
jamesdaniels Aug 16, 2022
7a6081f
Skip nuxt/windows/node:16
jamesdaniels Aug 16, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,21 @@ jobs:
needs: build
strategy:
matrix:
os: [ ubuntu-latest, macos-latest ]
node: [ "14", "16" ]
framework: [ "next", "angular", "custom" ]
os: [ ubuntu-latest, macos-latest, windows-latest ]
node: [ "16", "18" ]
framework: [ "next", "angular", "custom", "nuxt", "nuxt3" ]
exclude:
# seeing failures on this one, skip for now
- os: ubuntu-latest
node: 14
framework: angular
# Engine failures for Node 18
- node: 18
framework: next
- node: 18
framework: nuxt
- node: 18
framework: nuxt3
# JSON serialization problem
- node: 16
framework: nuxt
os: windows-latest
fail-fast: false
name: Test ${{ matrix.framework }} on Node ${{ matrix.node }} (${{ matrix.os }})
steps:
Expand Down Expand Up @@ -91,7 +98,7 @@ jobs:
- name: Test
run: |
npm i -g firebase-tools
npm i --only production --force --ignore-scripts --save --prefix $(npm root -g)/firebase-tools $(npm pack .)
node --loader ts-node/esm ./tools/dev.ts
firebase --open-sesame frameworkawareness
npm run test:${{ matrix.framework }}
env:
Expand All @@ -103,7 +110,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest, macos-latest ]
node: [ "14", "16" ]
node: [ "16" ] # lots of engine failures with Node 18, skip for now
exclude:
# we build with this combination, safely skip
- os: ubuntu-latest
Expand All @@ -130,11 +137,7 @@ jobs:
- name: Build
run: npm run build
- name: Test
run: |
npm i -g firebase-tools
npm i --only production --force --ignore-scripts --save --prefix $(npm root -g)/firebase-tools $(npm pack .)
firebase --open-sesame frameworkawareness
npm run test
run: npm run test
env:
FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}

Expand Down
Loading