add instructions to README.md #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for hacking on this, FYI the tests are a little flaky right now. Namely Node 14 on macos, so ignore, I disabled the branch protection policy for now. |
davideast
approved these changes
May 11, 2022
Co-authored-by: David East <[email protected]>
davideast
reviewed
May 11, 2022
davideast
reviewed
May 11, 2022
davideast
reviewed
May 11, 2022
|
@jamesdaniels this still requires a maintainer to approve before it can be merged. Can you take a look and merge? |
|
Skipping tests and review and merging since it's only README changes per David's request. |
thatfiredev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.