reading the Unicode parameter defined in the Code First mapping #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It all looks good to me. I think I need to check VARCHAR constants handling - there might be assumptions about stuff being UTF8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I'm using Google Translate.
I am creating this PR as directed through Twitter.
I made a small change in the src/FirebirdSql.EntityFrameworkCore.Firebird/Storage/Internal/FbTypeMappingSource.cs class to detect if the code is not setting the unicode attribute, as well as I changed the src/FirebirdSql.EntityFrameworkCore.Firebird/Storage/Internal/ class FbStringTypeMapping.cs to receive the mapping value.
If the Unicode attribute is not found, the code maintains the same pattern as before. In this case the default value = true
I'm making this contribution due to the need to turn off Unicode in the company's bases, with that, I came across this ignored implementation that makes me have to rebuild the provider with each new version.