Skip to content

Fix field evaluation in scaffolding #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2023
Merged

Fix field evaluation in scaffolding #1133

merged 2 commits into from
Aug 22, 2023

Conversation

bgrauer-atacom
Copy link
Contributor

@bgrauer-atacom bgrauer-atacom commented Aug 16, 2023 •
edited
Loading

@bgrauer-atacom bgrauer-atacom changed the title Fix nullable evaluation in scaffolding Fix evaluation in scaffolding Aug 18, 2023
@bgrauer-atacom
Copy link
Contributor Author

Well, it was not my intention to put two issues into the same pull request.
Let me know if you prefer two seperate pull requests.

@bgrauer-atacom bgrauer-atacom changed the title Fix evaluation in scaffolding Fix field evaluation in scaffolding Aug 18, 2023
@cincuranet
Copy link
Member

Single is fine.

@bgrauer-atacom
Copy link
Contributor Author

Fixed invalid test table length.

cincuranet
cincuranet requested changes Aug 21, 2023
View reviewed changes
@cincuranet
Copy link
Member

Remove the ScaffoldingTestsBase and I'll merge.

@bgrauer-atacom
Copy link
Contributor Author

Removed ScaffoldingTestsBase. Database objects are now not removed anymore.

@cincuranet
Copy link
Member

Thanks for your contribution.

@cincuranet cincuranet merged commit 19ee5db into FirebirdSQL:master Aug 22, 2023
@bgrauer-atacom
Copy link
Contributor Author

You are very welcome. Thanks for maintaining that project!
Let me know if you want my contribution in other issues.

@cincuranet
Copy link
Member

You're welcome to do what spikes your interest. Don't forget to review CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cincuranet cincuranet cincuranet requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgrauer-atacom @cincuranet