Skip to content

Fixed #8253 : Incorrect handling of non-ASCII object names in CREATE MAPPING statement #8254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fixed #8253 : Incorrect handling of non-ASCII object names in CREATE MAPPING statement #8254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e93268
Fixed bug #8253 : Incorrect handling of non-ASCII object names in CRE…
hvlad Sep 16, 2024
d519cb6
Always use single quotes around OS object names (user or group) in SH…
hvlad Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/dsql/DdlNodes.epp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10628,6 +10628,7 @@ void MappingNode::runInSecurityDb(SecDbContext* secDbContext)
ddl += ' ';
if (from)
{
ddl += "_utf8 ";
addItem(ddl, fromUtf8.c_str(), '\'');
ddl += ' ';
}
Expand Down
2 changes: 1 addition & 1 deletion src/dsql/parse.y
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7448,7 +7448,7 @@ map_from_symbol_name
%type <intlStringPtr> map_logoninfo
map_logoninfo
: sql_string
| valid_symbol_name { $$ = newNode<IntlString>($1->c_str()); }
| valid_symbol_name { $$ = newIntlString($1->c_str(), metadataCharSet->getName()); }
;

%type map_using(<mappingNode>)
Expand Down
2 changes: 1 addition & 1 deletion src/isql/show.epp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5142,7 +5142,7 @@ static void printMap(bool extract, bool global, char* name, char* usng, char* pl
isqlGlob.printf("FROM %s", anyObj ? "ANY " : "");
printIdent(extract, fromType, "%s ");
if (!anyObj)
printIdent(extract, from, "%s ");
isqlGlob.printf("\'%s\' ", from);

isqlGlob.printf("TO %s ", toType ? "ROLE" : "USER");
if (to)
Expand Down
Loading