Skip to content

fix: add null check for endSessionPromise #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

alfonsosn
Copy link
Contributor

@alfonsosn alfonsosn commented Feb 10, 2025

Description

Our team has been affected by a crash on Android and following the stack trace, this is what we see:

Exception java.lang.NullPointerException: Attempt to invoke interface method 'void com.facebook.react.bridge.Promise.resolve(java.lang.Object)' on a null object reference
  at com.rnappauth.RNAppAuthModule.onActivityResult (RNAppAuthModule.java:582)

We haven't been able to reproduce in our devices yet, but we do see that the following line doesn't have the null check that other promises have in this file:

            final Promise endSessionPromise = this.promise;
            WritableMap map = EndSessionResponseFactory.endSessionResponseToMap(response);
            endSessionPromise.resolve(map);

We believe that by adding a null pointer check on the endSessionPromise, we can remove this exception.

Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: 002266d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-app-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 7:08pm

@carbonrobot carbonrobot merged commit 3fb9a83 into FormidableLabs:main Mar 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants