ledmatrix: Enable sleep pin #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Detect if sleep pin is wired up, if not, just ignore it. So that we can support the first hardware revision. |
|
Done! @zachfeldman would you like to try to verify on your unit? Just to check if the firmware still works well on the old hardware revision. |
|
Btw if you are adventurous you can try to solder up the sleep pin by yourself. Not easy, Harris destroyed one pin while trying to do so. But luckily we have multiple unused ones that we can use, if needed. |
Turns LEDs off slowly and on slowly when sleep pin goes low/high. Signed-off-by: Daniel Schaefer <[email protected]>
Early revisions of the hardware didn't have it wired up, if that is the case we have to ignore its state. Signed-off-by: Daniel Schaefer <[email protected]>
|
Works fine on both hw revs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On first hw rev no change.
On second hw rev with pogo pins it'll go to sleep when the sleep pin is low.