windows: Statically link vcruntime DLL #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it won't run on some freshly installed machines. Windows complains that `vcruntime140.dll` is missing. Users would have to install the MSVC C++ Redistributable package. This is the same fix as in FrameworkComputer/qmk_hid. The measurements of that binary are: On a local build of `cargo clean; cargo build --release`: Size of .exe before: 857 KB Size of .exe after: 878 KB Note: Only affects release builds! I think that's because the debug version of this DLL isn't redistributable. Signed-off-by: Daniel Schaefer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it won't run on some freshly installed machines. Windows complains that
vcruntime140.dllis missing. Users would have to install the MSVC C++ Redistributable package.This is the same fix as in FrameworkComputer/qmk_hid#10. The measurements of that binary are:
On a local build of
cargo clean; cargo build --release: Size of .exe before: 857 KBSize of .exe after: 878 KB
Note: Only affects release builds! I think that's because the debug version of this DLL isn't redistributable.