MQTTv5 Implementation #316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| @@ -143,7 +134,9 @@ static int32_t sendBuffer( MQTTContext_t * pContext, | |||
| static MQTTStatus_t sendConnectWithoutCopy( MQTTContext_t * pContext, | |||
There was a problem hiding this comment.
We should audit the return values of all the functions in the doxygen documentation. Many of them are stale or non-exhaustive.
| } | ||
| else if( ( ( pIncomingPacket->remainingLength + variableLengthEncodedSize( pIncomingPacket->remainingLength ) + 1U ) > maxPacketSize ) && ( skipMaxPacketSizeCheck != true ) ) | ||
| { | ||
| LogError( ( "Packet Size cannot be greater than max packet size. " ) ); |
There was a problem hiding this comment.
We should add a log statement for this bad parameter return type.
source/core_mqtt_serializer.c
Outdated
| { | ||
| LogError( ( "pConnectProperties cannot be NULL for CONNACK packet." ) ); | ||
| status = MQTTBadParameter; | ||
| } |
There was a problem hiding this comment.
It would be better to document why the pConnectProperties parameter cannot be NULL for receiving a CONNACK packet. The reason is that even if the user does not want to parse the properties in the connack the server may still send them. THe properties in the connack are ought to be followed by the user. For instance, the max packet size of the server cannot be ignored by the user. Hence the user should process the connack properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading MQTT Library to support v5 features
Description
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.