Documentation spelling CI #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| config | ||
| css | ||
| hostname | ||
| hostnames |
There was a problem hiding this comment.
@ddeboer i guess proper english grammar would be "host name" should we keep as is?
There was a problem hiding this comment.
lets keep as is. its our techie-english :-)
|
awesome, thanks a lot @dantleech ! |
|
thanks a lot dan! |
dbu
added a commit
that referenced
this pull request
Feb 7, 2015
|
added a note in the contribution guide. found no good link about how to install enchant though. |
|
and created a PR on the bundle to add spell checking there as well. really useful, spotted a couple of funny things... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added spelling check for the documentation.
Note this is american english, i.e.
favoriteinstead offavourite,behaviorinstead ofbehaviour, I believe this is the Symfony standard.