Skip to content

Fixed linebreak #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2015
Merged

Fixed linebreak #181

merged 2 commits into from
Apr 2, 2015

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Apr 1, 2015

No description provided.

@@ -168,7 +168,8 @@ options through the constructor:

With Apache, you can do this for example in a ``.htaccess`` file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should end in :: instead to make the snippet below a proper code sample.

@ddeboer
Copy link
Member

ddeboer commented Apr 1, 2015

Thanks! While you’re at it, could you also change the colon line ending to make this into a proper code snippet?

@Nyholm
Copy link
Contributor Author

Nyholm commented Apr 1, 2015

Of course. I was not familiar with that syntax.
I've updated the file.

dbu added a commit that referenced this pull request Apr 2, 2015
@dbu dbu merged commit 2623071 into FriendsOfSymfony:master Apr 2, 2015
@dbu
Copy link
Contributor

dbu commented Apr 2, 2015

thanks @Nyholm - are you giving the FOSHttpCache a try or already using it?

@Nyholm Nyholm deleted the patch-1 branch April 2, 2015 08:19
@Nyholm
Copy link
Contributor Author

Nyholm commented Apr 2, 2015

Thank you for merging.
I'm giving it a try. I was stuck for some time due a bug in SensioFrameworkExtraBundle but apart from that the integration was easy.

@dbu
Copy link
Contributor

dbu commented Apr 2, 2015 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants