Skip to content

Update Documentation #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2015
Merged

Update Documentation #225

merged 1 commit into from
Jun 25, 2015

Conversation

zanbaldwin
Copy link
Contributor

Remove the call to flush() after invalidating tags from the tag handler, and add a note to explain why.
Fixes #221.

.. note::

The ``invalidateTags()`` method talks directly with the cache proxy for an
immediate affect. There is not need to call ``flush()``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a mistunderstanding. the tag handler talks with the CacheInvalidator. so you do need to call $cacheInvalidator->flush() at some point. you can link to the corresponding section in cache-invalidator with :ref:flush``.

Remove the call to flush() after invalidating tags from the tag handler, and add a note to explain why.
Fixes #221.
dbu added a commit that referenced this pull request Jun 25, 2015
@dbu dbu merged commit bb3ff1d into FriendsOfSymfony:master Jun 25, 2015
@dbu
Copy link
Contributor

dbu commented Jun 25, 2015

thanks a lot!

dbu added a commit that referenced this pull request Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants