[VCL] Keep user context headers in debug mode #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve debugging, and to be consistent with other cleanup keep headers if we are in debug mode.
dbu
approved these changes
Oct 1, 2018
There was a problem hiding this comment.
thank you! i think its not possible to return early. return in varnish can only jump to the next state that you specify e.g. return deliver;, so any further code for the current state won't be executed anymore. i think this is the correct way to do this, and makes a lot of sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve debugging, and to be consistent with other cleanup keep headers if we are in debug mode.
NOTE: If you know about a way to return early in a sane way here, we can do this without changing all the lines here.