clear response tagger after tagging to not leak tags from one response to the next #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrerom does this make sense? |
dbu
force-pushed
the
clean-tags-after-tagging
branch
2 times, most recently
from
ca3eca3 to
805a203
Compare
andrerom
approved these changes
Oct 3, 2018
src/ResponseTagger.php
Outdated
| @@ -143,10 +158,13 @@ public function tagResponse(ResponseInterface $response, $replace = false) | |||
| return $response; | |||
| } | |||
|
|
|||
| $value = $this->getTagsHeaderValue(); | |||
There was a problem hiding this comment.
$tagsHeaderValue if we want to be explicit
dbu
force-pushed
the
clean-tags-after-tagging
branch
from
805a203 to
bc9c1ff
Compare
|
thank you, readability is important! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in FriendsOfSymfony/FOSHttpCacheBundle#486
once this is merged, i will tag a patch release and update the bundle SymfonyResponseListener to also call
clear