Fixed missing request type in event

[Toflar]

I noticed there's a major issue in the CacheEvent because it's lacking the request type. If you want to send a request via $httpCache = $event->getKernel()->handle($$event->getRequest()) in an event listener yourself, you don't know the request type which means it's always going to be a master request even though it should be a sub request (e.g. Symfony's AbstractSurrogateHandler).

[dbu]

that makes sense and looks clean to me. can you please add a changelog entry for this? i'd consider it a new feature, not a bug, as nothing in the library itself is not working correctly, so the release for this would be 2.7.0

[Toflar]

Done, I've also added some unit tests :) I know it's rather a feature, it's just a pretty important one because I cannot fix my bug without having that feature 🙈

[Toflar]

Failing tests are unrelated. Something with the docs is not working.

[dbu]

yeah, the doc build fails because somethingsomething pyton/sphinx. i tried to fix it in #450 but no luck yet.

[dbu]

can you check out #453 please? i think we should use the HttpKernelInterface for the constants

[Toflar]

You could've just pushed to this PR 😄

[dbu]

do i have push rights in your copy of the repo?

I could also give you push rights here on the repo, if you want to become co-maintainer ;-)

[Toflar]

do i have push rights in your copy of the repo?

The checkbox "Allow edits from maintainers." is enabled by default 😄

I could also give you push rights here on the repo, if you want to become co-maintainer ;-)

I'll leave this decision up to you 😄