Update dispatch call #467
Update dispatch call #467
Conversation
| // LegacyEventDispatcherProxy exists in Symfony >= 4.3 | ||
| if (class_exists(LegacyEventDispatcherProxy::class)) { | ||
| // New Symfony 4.3 EventDispatcher signature | ||
| $this->getEventDispatcher()->dispatch($event, $name); |
There was a problem hiding this comment.
isn't the point of the legacy proxy that we then can use the same code regardless of dispatcher version?
There was a problem hiding this comment.
Apparently not. The LegacyEventDispatcherProxy triggers a deprecation notice if you use the old syntax: https://github.com/symfony/event-dispatcher/blob/4.3/LegacyEventDispatcherProxy.php#L63
And LegacyEventDispatcherProxy is not available in Symfony versions below 4.3 so there is no other way around this hack.
There was a problem hiding this comment.
but if we do all that, why do we use the legacy dispatcher at all? does it do anything for us, or could we just conditionally use the new order if we are on a new enough version?
There was a problem hiding this comment.
@dbu Because if somebody extends EventDispatchingHttpCache, the LegacyEventDispatcherProxy will make sure the old dispatcher syntax will continue to work.
I may have forgotten something in #463