Skip to content

update changelog #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2020
Merged

update changelog #478

merged 1 commit into from
Feb 24, 2020

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Feb 24, 2020

No description provided.

CHANGELOG.md Outdated
@@ -10,6 +10,7 @@ See also the [GitHub releases page](https://github.com/FriendsOfSymfony/FOSHttpC

* Raised minimal PHP version to 7.1
* Test helper classes upgraded to support PHPUnit 7/8
* Added [experimental support](https://foshttpcache.readthedocs.io/en/latest/proxy-clients.html#fastly-client) for [fastly](https://www.fastly.com/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added [experimental support](https://foshttpcache.readthedocs.io/en/latest/proxy-clients.html#fastly-client) for [fastly](https://www.fastly.com/)
* Added [experimental support](https://foshttpcache.readthedocs.io/en/latest/proxy-clients.html#fastly-client) for [fastly](https://www.fastly.com/)
* There is no discovery package 2.0, drop it from composer.json
* Adapt for changes to NetworkException in httplug 2.1 for PSR-18 compatibility

Copy link
Contributor

@andrerom andrerom Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, fastly is mentioned on 2.8.0 though:

Added Fastly ProxyClient Adapter with ClearCapable, PurgeCapable, RefreshCapable, & TagCapable.
  Fastly is a CDN originally based on Varnish 2.x, so with many of the same capabilities like VCL and more

So should be removed from there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, odd. it shows up in the git log of changes since 2.8.0 ... but yeah, will remove it again

Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that +1

@dbu dbu merged commit 7560f30 into master Feb 24, 2020
@dbu dbu deleted the changelog branch February 24, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants